refactor(grid): Remove deprecated usage of display density #14163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mdragnev/refactor-density
mddragnev
changed the title
…into mdragnev/refactor-density
…he resize observer
…UI/igniteui-angular into mdragnev/refactor-density
damyanpetev
reviewed
May 17, 2024
| @@ -435,7 +392,7 @@ export class IgxGridExcelStyleFilteringComponent extends BaseFilteringComponent | |||
| * @hidden @internal | |||
| */ | |||
| public hide() { | |||
| this._originalDisplay = document.defaultView.getComputedStyle(this.element.nativeElement).display; | |||
| this._originalDisplay = this.computedStyles.display; | |||
| this.element.nativeElement.style.display = 'none'; | |||
There was a problem hiding this comment.
👀
/* ignore this one, just baffled by why on earth is that doing */
...ects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-filtering.component.ts
Outdated
Show resolved
Hide resolved
…into mdragnev/refactor-density
damyanpetev
reviewed
May 21, 2024
| @@ -1,5 +1,5 @@ | |||
| <div class="wrapper"> | |||
| <igx-grid #grid1 [data]="data" [width]="'100%'" [height]="'800px'" displayDensity="compact" [rowSelection]="'multiple'" > | |||
| <igx-grid #grid1 [data]="data" [width]="'100%'" [height]="'800px'" [style.--ig-size]="1" [rowSelection]="'multiple'" > | |||
There was a problem hiding this comment.
PS: Those static values can just be moved to styles instead.
damyanpetev
previously approved these changes
May 21, 2024
…into mdragnev/refactor-density
simeonoff
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14015
Updated the update guide in the docfx: IgniteUI/igniteui-docfx#5807
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)