Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forof): Do not force setting master on each change. Set new sync master if the old one is not in the DOM #14362

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix(forof): Do not force setting master on each change. Set new sync master if the old one is not in the DOM #14362

merged 3 commits into from
Jun 17, 2024

Conversation

mddragnev
Copy link
Member

Closes #14039

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 17, 2024
@IMinchev64 IMinchev64 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 17, 2024
@dkamburov dkamburov merged commit 30e5735 into 18.0.x Jun 17, 2024
4 checks passed
@dkamburov dkamburov deleted the mdragnev/fix-14039-18.0.x branch June 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

Assignees

@dkamburov dkamburov

@IMinchev64 IMinchev64

Labels
grid version: 18.0.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mddragnev @MayaKirova @dkamburov @ChronosSF @IMinchev64