Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(grid): mark lastSearchInfo readonly/getter-only #14389

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Jun 13, 2024

Generally would like public writable properties to also be @Input-s, however there should be no meaningful use case that requires setting lastSearchInfo entirely or any of it's properties for that matter. As the name suggest that's cached search details so marking the property readonly/making it a getter.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev merged commit 3f72185 into 18.0.x Jun 14, 2024
3 of 4 checks passed
@damyanpetev damyanpetev deleted the dpetev/grid-last-search-info-getter-18.0 branch June 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants