Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESF on igx-grid does not reflect current filters in esf dialog --18.0.x #14436

Merged
merged 30 commits into from
Jul 2, 2024
Merged

ESF on igx-grid does not reflect current filters in esf dialog --18.0.x #14436

merged 30 commits into from
Jul 2, 2024

Conversation

ddincheva
Copy link
Contributor

Closes #14188

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

ddincheva and others added 11 commits June 25, 2024 17:05
@ddincheva
feat(ESF): show the current filtering conditions in esf dialog
370553f
@ddincheva
fix(ESF): return correctly if filtering is applied on a column #14188
c421b96
@ddincheva
feat(esf): selected style on filter condition & number of filter oper…
d9c7880 
…ands #14188
@ddincheva
feat(*): show already applied filter operands in filter dialog #14188
a615b3a
@ddincheva
feat(*): no emitted event on dd when change selected through API #14188
49a4fff
@ddincheva
chore(*): fix linting error
df6e2d1
@ddincheva
chore(*): select drop down item without throwing selectionChanging event
0e79edb
@deyvidnenchev @ddincheva
feat(*): set bttn label from unique columns inst of num of filtering …
5017ba0 
…operands
@ddincheva
chore(*): recalc the number of filtered columns only when filtering i…
d653812 
…s changed
@ddincheva
chore(*): address the review comments and remove the redundant code
f4f66bd
@ddincheva
chore(*): fix tests due to method signature change
3f7b657
ddincheva and others added 12 commits June 26, 2024 10:41
@ddincheva
chore(dropDown): return back the order of params for selectItem method
2563ed9
@ddincheva
Merge branch '18.0.x' into ddincheva/filteringDialog-18.0
cec2c3c
@ddincheva
chore(*): remove unnecessary param from the tests
5c5987b
@ddincheva
Merge branch 'ddincheva/filteringDialog-18.0' of https://github.com/I…
b22a0c1 
…gniteUI/igniteui-angular into ddincheva/filteringDialog-18.0
@ddincheva
chore(*): address all the review comments
0688333
@ddincheva
chore(*): add some ui test that verify number of filtered columns
c51014d
@ddincheva
chore(*): add test for selected state of filtered operand applied
b7dd3ba
@ddincheva
chore(*): add more test to verify previous value is shown in esf dialog
9869c5e
@hanastasov
Merge branch '18.0.x' into ddincheva/filteringDialog-18.0
ba93e9e
@ddincheva
Merge branch '18.0.x' into ddincheva/filteringDialog-18.0
ca8f958
@ddincheva
Merge branch 'ddincheva/filteringDialog-18.0' of https://github.com/I…
4736f9a 
…gniteUI/igniteui-angular into ddincheva/filteringDialog-18.0
@ddincheva
chore(*): remove unnecessary test
dcdedda
@hanastasov hanastasov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 2, 2024
@hanastasov hanastasov merged commit a2c706e into 18.0.x Jul 2, 2024
4 checks passed
@hanastasov hanastasov deleted the ddincheva/filteringDialog-18.0 branch July 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov approved these changes

@deyvidnenchev deyvidnenchev Awaiting requested review from deyvidnenchev

Assignees
No one assigned
Labels
grid: advanced-filtering grid: excel-style-filtering grid: filter-ui version: 18.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddincheva @hanastasov @deyvidnenchev