Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav drawer - fixing navdrawer item in material theme to work with ripple directive #14574

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Nav drawer - fixing navdrawer item in material theme to work with ripple directive #14574

merged 3 commits into from
Jul 31, 2024

Conversation

desig9stein
Copy link
Contributor

Closes #14554

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff linked an issue Jul 29, 2024 that may be closed by this pull request
Nav drawer items ripple size doesn't match #14554
Closed
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 31, 2024
@simeonoff simeonoff assigned simeonoff and unassigned damyanpetev Jul 31, 2024
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 31, 2024
@simeonoff simeonoff merged commit 56b32d2 into 18.1.x Jul 31, 2024
3 of 4 checks passed
@simeonoff simeonoff deleted the mpopov/fix-for-14554-18.0.1 branch July 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@simeonoff simeonoff

Labels
material-theme nav-drawer version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nav drawer items ripple size doesn't match
3 participants
@desig9stein @simeonoff @damyanpetev