Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(advance-filtering): handle error when columns are dynamically changed - 18.1.x #14577

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

georgianastasov
Copy link
Contributor

Closes #14314

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddincheva
Copy link
Contributor

Since the PR to master with these changes is closed, I am leaving links to the comments and the remaining concerns here:
#14525 (comment)
#14525 (comment)
Please log an issue with the new task regarding the UX experience when filtering is applied and the data of the grid is changed and link it here .. in order to have better tracking

@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 26, 2024
@kacheshmarova kacheshmarova merged commit 98436d5 into 18.1.x Jul 29, 2024
4 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/fix-14314-18.1.x branch July 29, 2024 06:56
@georgianastasov
Copy link
Contributor Author

I have logged the new task regarding the UX experience when filtering is applied and the data of the grid is changed. You can track it here: #14595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: advanced-filtering grid version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid Advanced Filtering throws if grid has recreated its columns colection
4 participants