feat(grid): optimize grid row selection flow and performance - master #14610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgianastasov
added
❌ status: awaiting-test
georgianastasov
changed the title
hanastasov
requested changes
Sep 5, 2024
projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
Outdated
Show resolved
Hide resolved
hanastasov
reviewed
Sep 5, 2024
hanastasov
reviewed
Sep 5, 2024
projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
Outdated
Show resolved
Hide resolved
hanastasov
reviewed
Sep 19, 2024
projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
Outdated
Show resolved
Hide resolved
| const unSelectedRows = allData.filter(row => !selectedData.has(row)); | ||
| return this.allRowsSelected = this.allData.length > 0 && unSelectedRows.length === 0; | ||
| allData = allData || this.allData; | ||
| const selectedData = new Set(newSelection ? newSelection.map(r => this.getRecordKey(r)) : [...this.rowSelection]); |
There was a problem hiding this comment.
This line is basically the same as
const selectedData = this.getRowIDs(newSelection || this.rowSelection);
So, maybe is better to use the abstracted getRowIDs:
- better use it, thats why it is exposed at all
- makes reading code better
- makes less diff, so easier to review PR
There was a problem hiding this comment.
When #14610 (comment) gets resolved, it will not be needed at all to do mapping over newSelection again. Still, verify that assumption.
There was a problem hiding this comment.
I chose to use this approach: keep the newSelection in its original format until after the rowSelectionChanging event is emitted. This way, the selection data remains consistent throughout the event lifecycle, allowing the handler to correctly manipulate it as needed. This approach ensures proper functionality without any test failures.
hanastasov
approved these changes
Sep 30, 2024
Zneeky
added
💥 status: in-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14519
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)