Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-service): get theme from component stylesheet instead of the global theme #14622

Merged
merged 9 commits into from
Aug 14, 2024
Merged

fix(theme-service): get theme from component stylesheet instead of the global theme #14622

merged 9 commits into from
Aug 14, 2024

Conversation

simeonoff
Copy link
Collaborator

Closes #14566

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff changed the title Simeonoff/fix theming service fix(theming-service): get theme from component stylesheet instead of the global one Aug 12, 2024
@simeonoff simeonoff changed the title fix(theming-service): get theme from component stylesheet instead of the global one fix(theming-service): get theme from component stylesheet instead of the global theme Aug 12, 2024
@simeonoff simeonoff changed the title fix(theming-service): get theme from component stylesheet instead of the global theme fix(theme-service): get theme from component stylesheet instead of the global theme Aug 13, 2024
SisIvanova
SisIvanova previously approved these changes Aug 13, 2024
View reviewed changes
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 14, 2024
@simeonoff simeonoff merged commit 2f0d40a into 18.1.x Aug 14, 2024
3 of 4 checks passed
@simeonoff simeonoff deleted the simeonoff/fix-theming-service branch August 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova SisIvanova left review comments

Assignees

@dobromirts dobromirts

@SisIvanova SisIvanova

Labels
✨ themes version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simeonoff @SisIvanova @dobromirts