-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slider): improve accessibility by correcting ARIA attributes and tab index - master #14793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgianastasov
added
❌ status: awaiting-test
PRs awaiting manual verification
slider
♿ a11y
When the issue or PR is related to accessibility
version: 18.2.x
labels
Sep 19, 2024
hanastasov
added
💥 status: in-test
PRs currently being tested
and removed
❌ status: awaiting-test
PRs awaiting manual verification
labels
Sep 27, 2024
hanastasov
requested changes
Sep 27, 2024
projects/igniteui-angular/src/lib/slider/thumb/thumb-slider.component.ts
Outdated
Show resolved
Hide resolved
georgianastasov
added
❌ status: awaiting-test
PRs awaiting manual verification
and removed
💥 status: in-test
PRs currently being tested
labels
Sep 30, 2024
hanastasov
approved these changes
Oct 22, 2024
RivaIvanova
added
💥 status: in-test
PRs currently being tested
and removed
❌ status: awaiting-test
PRs awaiting manual verification
labels
Oct 22, 2024
RivaIvanova
added
✅ status: verified
Applies to PRs that have passed manual verification
and removed
💥 status: in-test
PRs currently being tested
labels
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
slider
version: 18.2.x
♿ a11y
When the issue or PR is related to accessibility
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14262
The slider control element now follows ARIA guidelines, including:
The slider thumb component has been updated to follow ARIA accessibility guidelines as per WAI-ARIA slider pattern and the implementations outlined in the IgniteUI Web Components Slider specification.
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)