Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grid, pivot): add deprecation proxy for shouldGenerate to autoGenerate #14797

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

georgianastasov
Copy link
Contributor

Related to #14315

This PR refactors the existing deprecation of the shouldGenerate property in the grid and pivot-grid components. It now acts as a proxy to the already existing autoGenerate property using getter and setter methods. This enhancement ensures backward compatibility and simplifies the transition process for users still relying on the deprecated property.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 26, 2024
@kacheshmarova kacheshmarova merged commit 43e5c9d into master Sep 27, 2024
5 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/refactor-14315-master branch September 27, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: pivot grid refactoring version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants