Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(banner-theme): add support for anchor elements as action items #14800

Merged
merged 1 commit into from
Sep 24, 2024
Merged

refactor(banner-theme): add support for anchor elements as action items #14800

merged 1 commit into from
Sep 24, 2024

Conversation

simeonoff
Copy link
Collaborator

Closes #12594

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff added ❌ status: awaiting-test PRs awaiting manual verification banner Banner component ✨ themes version: 18.1.x labels Sep 19, 2024
@desig9stein desig9stein added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 21, 2024
@desig9stein desig9stein self-assigned this Sep 21, 2024
@simeonoff simeonoff merged commit 108bfbb into 18.1.x Sep 24, 2024
5 checks passed
@simeonoff simeonoff deleted the simeonoff/fix-12594-18.1.x branch September 24, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desig9stein desig9stein desig9stein approved these changes

Assignees

@desig9stein desig9stein

Labels
banner Banner component ✨ themes version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simeonoff @desig9stein