Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ExcelExporter): Remove the null char from cell value #14995

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix(ExcelExporter): Remove the null char from cell value #14995

merged 1 commit into from
Nov 1, 2024

Conversation

gedinakova
Copy link
Contributor

@gedinakova gedinakova commented Nov 1, 2024 •
edited
Loading

Closes #14944

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@gedinakova gedinakova requested a review from Otixa November 1, 2024 09:14
Otixa
Otixa approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@Otixa Otixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@onlyexeption onlyexeption added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 1, 2024
@kdinev kdinev merged commit d67cc3d into 18.2.x Nov 1, 2024
3 checks passed
@kdinev kdinev deleted the gedinakova/fix-null-char-14944-18.2 branch November 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otixa Otixa Otixa approved these changes

Assignees

@onlyexeption onlyexeption

Labels
excel-exporter version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gedinakova @Otixa @kdinev @onlyexeption