feat(typography): implement typography functions and mixins to the material spec #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # projects/igniteui-angular/src/lib/core/styles/components/checkbox/_checkbox-theme.scss
# Conflicts: # projects/igniteui-angular/src/lib/core/styles/themes/_core.scss
simeonoff
added
feature
❌ status: awaiting-test
desig9stein
previously approved these changes
Jul 30, 2018
wnvko
previously approved these changes
Aug 1, 2018
# Conflicts: # projects/igniteui-angular/src/lib/combo/combo.component.spec.ts # projects/igniteui-angular/src/lib/test-utils/helper-utils.spec.ts
desig9stein
previously approved these changes
Aug 9, 2018
…ular into PR2112/checkout
kdinev
approved these changes
Aug 20, 2018
zdrawku
added
💥 status: in-test
zdrawku
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
@simeonoff, kudos for the great work that you have done with the Typography in Ignite UI for Angular!
Documentation, Readme.md and implementation of all mixins and functions are very well explained and intuitive to use.
I strongly hope that out clients will benefit of this powerful type system and will use it with ease.
I have uploaded part of my testing implementation in a GitHub repository
zdrawku
added
✅ status: verified
rkaraivanov
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1351
Breaking Changes:
igx-typographyclass to be applied on wrapping element, like the body element for instance.