IgxTreeGrid - Editing #2909

ViktorSlavov · 2018-11-02T06:57:02Z

Closes #2908.

# Conflicts: # projects/igniteui-angular/src/lib/grids/api.service.ts

…2530

…eGrid-editing

…I/igniteui-angular into VSlavov/treeGrid-editing

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-expanding.spec.ts

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-integration.spec.ts

…eGrid-editing # Conflicts: # projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

damyanpetev · 2018-11-02T16:59:34Z

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

+        %grid-cell-text {
+            font-style: italic;
+            color: igx-color(map-get($theme, 'palette'), 'error');
+            text-decoration-line: line-through;


@simeonoff Can't this be just text-decoration so it'd work in IE/Edge too?
@StefanIvanov Is red part of the design?

@damyanpetev text-decoration-line is just a property of the shorthand text-decoration. The line-through text decoration is not supported in IE and Edge. As to the color being red, I've discussed it with @StefanIvanov before implementing the change.

@simeonoff Despite being the shorthand, text-decoration: line-through; is in the CSS1 spec and works just fine even in older IE-s. So unless we need any of the decorations, can we use the shorthand for consistency?

…eGrid-editing # Conflicts: # projects/igniteui-angular/src/lib/grids/api.service.ts # projects/igniteui-angular/src/lib/grids/grid-base.component.ts

…tions

damyanpetev · 2018-11-05T07:23:11Z

projects/igniteui-angular/src/lib/grids/grid-base.component.ts

@@ -4385,7 +4391,14 @@ export abstract class IgxGridBaseComponent implements OnInit, OnDestroy, AfterCo
    public repositionRowEditingOverlay(row: IgxRowComponent<IgxGridBaseComponent>) {
        this.configureRowEditingOverlay(row.rowID);
        if (!this.rowEditingOverlay.collapsed) {
-            this.rowEditingOverlay.reposition();
+            const rowStyle = this.rowEditingOverlay.element.parentElement.style;
+            if (row) {


There's something not quite right here - if the method accepts a call without a row, the .configureRowEditingOverlay(row.rowID) right above doesn't and will error out (see tests). Also what's with .configureRowEditingOverlay(row) below - is it row or rowID?

…2530

…I/igniteui-angular into VSlavov/treeGrid-editing

…ons, #2908

DiyanDimitrov and others added 30 commits October 26, 2018 16:53

feat(tree-grid): adding tree grid component #2530

ac351bc

feat(tree-grid): fixing some style classes #2530

1c819d8

Merge branch 'master' into ddimitrov/IgxTreeGrid

1fc943f

# Conflicts: # projects/igniteui-angular/src/lib/grids/api.service.ts

feat(tree-grid): fixing test references #2530

cf45e3c

Merge branch 'master' into ddimitrov/IgxTreeGrid

9b5c8a2

feat(tree-grid): fixing some more test references #2530

f27a008

Merge branch 'master' into ddimitrov/IgxTreeGrid

fd53939

feat(tree-grid): fixing lint errors #2530

a16e48b

Merge branch 'master' into ddimitrov/IgxTreeGrid

1a9121c

Merge branch 'master' into ddimitrov/IgxTreeGrid

7c94bc9

feat(tree-grid): fixing tree cell selection and editing #2530

9c65956

feat(tree-grid): fixing row selection #2530

ae5e928

feat(tree-grid): fixing tree column auto-sizing #2530

4c37600

feat(tree-grid): applying some changes to the destroyMap #2530

13f5e0b

feat(tree-grid): fixing the CRUD operations #2530

358ba06

feat(tree-grid): adding tree-cell style #2530

4e52138

feat(tree-grid): add pending to a failing test #2530

7bab4ce

fix(igxTreeGrid): update treegrid API to incorp. editing, #2530

13a87d3

feat(tree-grid): moving some grouping specific code #2530

5a96282

feat(tree-grid): hiding summaries until implemented #2530

e59f5a8

fix(igxGrid): add TreeGridTransaction pipe, update mergeTransactions, #…

01636ec

…2530

feat(tree-grid): hide exporters for TreeGrid #2530

b65c83b

Merge branch 'master' into ddimitrov/IgxTreeGrid

88e1add

feat(tree-grid): removing defaultDropArea from TreeGrid #2530

b9c2552

feat(tree-grid): fixing lint errors #2530

e51ba43

feat(tree-grid): adding configureTestSuite to TreeGrid tests #2530

d14b5d1

feat(tree-grid): fixing tree grid sample description #2530

cb785b3

feat(tree-grid): adding some missing cofigureTestSuite calls #2530

d160e78

test(TreeGridCrud): #2530 Removing done from async tests.

5d31112

test(ColPinning): #2530 Fixed an issue in afterAll();

7cffb14

wnvko and others added 6 commits November 2, 2018 13:58

Merge remote-tracking branch 'remotes/origin/master' into VSlavov/tre…

2532d34

…eGrid-editing

refactor(tree-grid): adding tree data structure to transaction

cf6db67

refactor(tree-grid): clearStateForDeletedItems checks if node provided

df4d3ef

fix(row-editing): fix delete row in transation

2838309

refactor(tree-grid): add path to ITreeGridRecord

c0220a3

Merge branch 'VSlavov/treeGrid-editing' of https://github.com/IgniteU…

275f8dd

…I/igniteui-angular into VSlavov/treeGrid-editing

gedinakova requested changes Nov 2, 2018

View reviewed changes

wnvko added 3 commits November 2, 2018 17:57

refactor(tree-grid): add /** @experimental @hidden */ where needed

590f51e

Merge remote-tracking branch 'remotes/origin/master' into VSlavov/tre…

c95cf69

…eGrid-editing # Conflicts: # projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

test(tree-grid): fix row edit tests, #2878

10f45f8

damyanpetev reviewed Nov 2, 2018

View reviewed changes

wnvko and others added 3 commits November 3, 2018 19:51

Merge remote-tracking branch 'remotes/origin/master' into VSlavov/tre…

75b6f6e

…eGrid-editing # Conflicts: # projects/igniteui-angular/src/lib/grids/api.service.ts # projects/igniteui-angular/src/lib/grids/grid-base.component.ts

refactor(tree-grid): push cascaded flat delete row as pending transac…

7c25eca

…tions

chore(lint): more row's new method after property definitions

a66445f

damyanpetev requested changes Nov 5, 2018

View reviewed changes

jackofdiamond5 and others added 9 commits November 5, 2018 10:27

test(row-editing): added selection tests and updated filtering tests #…

964e8ec

…2530

refactor(tree-grid): add useInUndo flag

61bbf85

Merge branch 'VSlavov/treeGrid-editing' of https://github.com/IgniteU…

df04c08

…I/igniteui-angular into VSlavov/treeGrid-editing

fix(tree-grid): check row existence #2908

536e195

test(tree-grid): fix failing test with missing component in declarati…

161668a

…ons, #2908

fix(igx-grid): pass correct argument #2908

0ba0f52

fix(igx-grid): remove unnecessary code #2908

6ebcfba

fix(igx-treegrid): end row edit on expand/collpase #2908

423bde9

fix(igx-grid): end row edit on expand/collpase #2908

31fbbb2

damyanpetev approved these changes Nov 5, 2018

View reviewed changes

gedinakova approved these changes Nov 5, 2018

View reviewed changes

Lipata added ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 5, 2018

bazal4o merged commit e9843b4 into master Nov 5, 2018

bazal4o deleted the VSlavov/treeGrid-editing branch November 5, 2018 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IgxTreeGrid - Editing #2909

IgxTreeGrid - Editing #2909

ViktorSlavov commented Nov 2, 2018

damyanpetev Nov 2, 2018

simeonoff Nov 2, 2018 •

edited

Loading

damyanpetev Nov 5, 2018

damyanpetev Nov 5, 2018

IgxTreeGrid - Editing #2909

IgxTreeGrid - Editing #2909

Conversation

ViktorSlavov commented Nov 2, 2018

damyanpetev Nov 2, 2018

Choose a reason for hiding this comment

simeonoff Nov 2, 2018 • edited Loading

Choose a reason for hiding this comment

damyanpetev Nov 5, 2018

Choose a reason for hiding this comment

damyanpetev Nov 5, 2018

Choose a reason for hiding this comment

simeonoff Nov 2, 2018 •

edited

Loading