Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keyboard navigation in filtering #2963

Merged
merged 8 commits into from
Nov 9, 2018
Merged

Improve keyboard navigation in filtering #2963

merged 8 commits into from
Nov 9, 2018

Conversation

sstoyanovIG
Copy link
Contributor

Closes #2951, #2941

@sstoyanovIG sstoyanovIG requested a review from bkulov November 7, 2018 15:51
@sstoyanovIG sstoyanovIG changed the title Improve keyboard navigation in filtering, #2951 Improve keyboard navigation in filtering Nov 7, 2018
@npaunov npaunov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 8, 2018
@npaunov npaunov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 8, 2018
bkulov
bkulov suggested changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@bkulov bkulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my remarks in the corresponding PR:
#2964

@npaunov npaunov added 💥 status: in-test PRs currently being tested and removed ✅ status: verified Applies to PRs that have passed manual verification labels Nov 8, 2018
bkulov
bkulov previously approved these changes Nov 8, 2018
View reviewed changes
@npaunov npaunov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 8, 2018
bkulov
bkulov previously approved these changes Nov 9, 2018
View reviewed changes
@bkulov bkulov merged commit e100e62 into master Nov 9, 2018
@bkulov bkulov deleted the sstoyanov/bug-fix-2951 branch November 9, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkulov bkulov bkulov approved these changes

Assignees

@npaunov npaunov

Labels
filtering grid: general keyboard-navigation ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstoyanovIG @bkulov @npaunov