Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move igniteui-cli as a dev dependency #3273

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Move igniteui-cli as a dev dependency #3273

merged 2 commits into from
Dec 4, 2018

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Dec 3, 2018 •
edited
Loading

Closes #3254

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ViktorSlavov ViktorSlavov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 3, 2018
@damyanpetev damyanpetev changed the title Flagged igniteui-cli as a dev dependency Move igniteui-cli as a dev dependency Dec 3, 2018
@damyanpetev damyanpetev changed the base branch from master to 7.0.x December 3, 2018 15:13
@damyanpetev
Copy link
Member

@jackofdiamond5 If it's 7.0.2 it should be targeted at 7.0.x branch.
I've changed the PR target and will rebase the branch in a bit

@damyanpetev damyanpetev merged commit 56d63b2 into 7.0.x Dec 4, 2018
@damyanpetev damyanpetev deleted the bpenkov/schematics-dep-fix branch December 4, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

@ViktorSlavov ViktorSlavov

Labels
ng add version: 7.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackofdiamond5 @damyanpetev @ViktorSlavov