fix(time picker): IE cursor flickering on spinning #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAndreeva
added
❌ status: awaiting-test
bkulov
suggested changes
Jan 8, 2019
| public ngAfterViewInit(): void { | ||
| if (this.mode === TimePickerInteractionMode.dropdown) { | ||
| fromEvent(this.input.nativeElement, 'keydown').pipe( | ||
| throttle(() => interval(0, animationFrameScheduler)), |
There was a problem hiding this comment.
There is no sense to throttle events for 0 ms. I think setting the interval to 300 ms would make more sense.
There was a problem hiding this comment.
interval(0, animationFrameScheduler) creates an observable that emits one event every time the browser is ready to display a new frame and then the throttle operator will emit a value from that source observable.
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
sboykova
added
💥 status: in-test
sboykova
added
✅ status: verified
bkulov
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes