Adding ng-content to IgxSnackbar - master #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedinakova
previously approved these changes
Jan 8, 2019
gedinakova
added
version: 7.2.x
❌ status: awaiting-test
gedinakova
previously approved these changes
Jan 10, 2019
rmkrmk
added
💥 status: in-test
kdinev
previously approved these changes
Jan 10, 2019
kdinev
reviewed
Jan 10, 2019
| @@ -1,6 +1,9 @@ | |||
| <div class="igx-snackbar" *ngIf="isVisible" (@slideInOut.start)="snackbarAnimationStarted($event)" (@slideInOut.done)="snackbarAnimationDone($event)" | |||
| [@slideInOut]="isVisible"> | |||
| <span class="igx-snackbar__message" [@fadeInOut]="isVisible">{{ message }}</span> | |||
| <div class="igx-snackbar__message"> | |||
There was a problem hiding this comment.
One question remains. If you leave this as, then all the content will fadeIn/out, and the message will be displayed only if it exists:
<div class="igx-snackbar__message" [@fadeInOut]="isVisible">
{{ message }}
<ng-content></ng-content>
</div>
@simeonoff Do we need a container for the message, in terms of styling?
kdinev
previously approved these changes
Jan 11, 2019
gedinakova
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3328
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes