fix(filtering): chips creation while typing in JP on Edge #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAndreeva
added
🐛 bug
sstoyanovIG
suggested changes
Jan 15, 2019
There was a problem hiding this comment.
This way the value will always update, no matter what the result of the 'if statement' is. As a result #3504 is now reproducible.
sstoyanovIG
added
💥 status: in-test
kdinev
previously approved these changes
Jan 16, 2019
bkulov
approved these changes
Jan 16, 2019
bkulov
suggested changes
Jan 16, 2019
| @@ -286,7 +286,9 @@ export class IgxGridFilteringRowComponent implements AfterViewInit { | |||
| public onInput(eventArgs) { | |||
| // The 'iskeyPressed' flag is needed for a case in IE, because the input event is fired on focus and for some reason, | |||
| // when you have a japanese character as a placeholder, on init the value here is empty string . | |||
| if (this.isKeyPressed) { | |||
| if (isEdge()) { | |||
There was a problem hiding this comment.
You can combine the two if clauses as their blocks are the same.
bkulov
approved these changes
Jan 16, 2019
sstoyanovIG
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3599
Additional information (check all that apply):
Checklist:
NOTE:
Please check #3504 again to make sure we have not regressed it.