fix(igxGrid): Grid should render all columns when grid width is set to null. #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayaKirova
added
❌ status: awaiting-test
skrustev
previously requested changes
Jul 17, 2019
| if (this.width === null && this.columnList && this.columnList.length > 0) { | ||
| let width = this.columnList.reduce((sum, item) => sum + parseInt((item.width || item.defaultWidth), 10), 0); | ||
| if (this.hasVerticalSroll()) { | ||
| width += this.scrollWidth; |
There was a problem hiding this comment.
It should add also the features extra columns width and etc.
Otherwise for example if Row Selection is enabled it will create scrollbar because the column containing checkboxes is not taken into account.
…at change the total grid width (row selectors, expansion indicators etc.).
3phase
added
💥 status: in-test
added 2 commits
July 18, 2019 16:11
…nto account when calculating virtualization width as it should be equal to the sum of column widths.
…n width is set to null.
3phase
added
✅ status: verified
ChronosSF
previously approved these changes
Jul 23, 2019
ChronosSF
added
💥 status: in-test
|
Check the new issues in #5397 |
…dings so that grid will expact based on content. In case width is null and column width in % then set width to min width explicitly.
…/igniteui-angular into mkirova/fix-5288-master
MayaKirova
added
❌ status: awaiting-test
|
@MayaKirova, the only issue still remaining is that the row drag column remains as empty area after row drag is disabled:
|
ChronosSF
added
💥 status: in-test
added 2 commits
August 2, 2019 11:29
|
@ChronosSF Please re-test. |
ChronosSF
added
✅ status: verified
dkamburov
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5288
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes