-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(igxHierarchicalGrid): Fixing navigation when parent has summary b… #5410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut child does not.
MayaKirova
added
❌ status: awaiting-test
PRs awaiting manual verification
keyboard-navigation
grid: hierarchical-grid
version: 8.1.x
labels
Jul 12, 2019
dkamburov
previously approved these changes
Jul 19, 2019
mpavlinov
added
🛠️ status: in-development
Issues and PRs with active development on them
and removed
❌ status: awaiting-test
PRs awaiting manual verification
labels
Jul 24, 2019
@MayaKirova I found 2 problems: Cannot read property 'childGridsData' of undefinedSteps
Cannot read property 'length' of nullSteps
Note: I couldn't reproduce those in 8.1.0 |
…focus should move on to the next child or parent row.
MayaKirova
added
❌ status: awaiting-test
PRs awaiting manual verification
and removed
🛠️ status: in-development
Issues and PRs with active development on them
labels
Jul 26, 2019
ChronosSF
approved these changes
Jul 30, 2019
mpavlinov
added
💥 status: in-test
PRs currently being tested
and removed
❌ status: awaiting-test
PRs awaiting manual verification
💥 status: in-test
PRs currently being tested
labels
Jul 31, 2019
mpavlinov
added
the
✅ status: verified
Applies to PRs that have passed manual verification
label
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
grid: hierarchical-grid
keyboard-navigation
version: 8.1.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut child does not.
Closes #4416
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes