Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grids): handle double tap to allow editing on iOS #2538 #5461

Merged
merged 4 commits into from
Aug 5, 2019
Merged

fix(grids): handle double tap to allow editing on iOS #2538 #5461

merged 4 commits into from
Aug 5, 2019

Conversation

damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Jul 18, 2019 •
edited
Loading

Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.

Closes #2538

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev
fix(grids): handle double tap to allow editing on iOS #2538
937968d 
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.
@damyanpetev
chore(grids): strongly type doubletap event for preventDefault call
7eebad0 
Due to incompatible signatures (void vs Function) w/ older ts 3.2
@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 1, 2019
@Lipata Lipata merged commit 2e62f6e into 7.2.x Aug 5, 2019
@Lipata Lipata deleted the dpetev/ios-grid-edit-7-2 branch August 5, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

@ChronosSF ChronosSF Awaiting requested review from ChronosSF

@zdrawku zdrawku Awaiting requested review from zdrawku

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

Assignees

@PlamenaMiteva PlamenaMiteva

Labels
grid: cell-editing grid: general grid: hierarchical-grid grid: tree-grid version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damyanpetev @MayaKirova @Lipata @PlamenaMiteva @kdinev