Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update evaluating of 'grid-template-rows' style to reflect how chrome 76 sets it now. #5567

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Update evaluating of 'grid-template-rows' style to reflect how chrome 76 sets it now. #5567

merged 4 commits into from
Aug 2, 2019

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Aug 1, 2019 •
edited
Loading

#5556

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD
  • Tests

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev skrustev changed the title test(MRL): Update evaluating of 'grid-template-rows' style to reflect how chrome 76 sets it now. Update evaluating of 'grid-template-rows' style to reflect how chrome 76 sets it now. Aug 1, 2019
@skrustev skrustev force-pushed the SKrastev/fix-mrl-tests-8.1.x branch from 4d57434 to ace9ca8 Compare August 1, 2019 13:43
MayaKirova
MayaKirova previously approved these changes Aug 1, 2019
View reviewed changes
@ChronosSF ChronosSF requested review from hanastasov and MayaKirova and removed request for ChronosSF August 2, 2019 11:49
@kdinev kdinev merged commit f030eb2 into 8.1.x Aug 2, 2019
@kdinev kdinev deleted the SKrastev/fix-mrl-tests-8.1.x branch August 2, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

@hanastasov hanastasov Awaiting requested review from hanastasov

Assignees

@mpavlinov mpavlinov

Labels
grid: multi-row-layout 🧪 ci: tests version: 8.1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skrustev @MayaKirova @kdinev @mpavlinov @ChronosSF