Skip to content

feat(themes): Add RTL styling #5854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 82 commits into from
Oct 21, 2019
Merged

feat(themes): Add RTL styling #5854

merged 82 commits into from
Oct 21, 2019

Conversation

@simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Sep 25, 2019 •
edited
Loading

Closes #5791

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff changed the title feat(themes): add helper mixins and fucntions to aid with RTL feat(themes): add helper mixins and functions to aid with RTL Sep 25, 2019
MPopov and others added 2 commits September 26, 2019 15:09
@zdrawku zdrawku changed the base branch from master to 8.2.x September 27, 2019 08:34
MPopov and others added 20 commits September 30, 2019 10:22
feat(combo): Adding RTL support for combo component
a269ea2 
Signed-off-by: MPopov <desig9stein@gmail.com>
@simeonoff
refactor(switch, checkbox): add support for RTL direction
c34f658
feat(Dialog): Adding RTL support for dialog component
a2bcc2e 
Signed-off-by: MPopov <desig9stein@gmail.com>
Merge remote-tracking branch 'IGX/RTL-support' into RTL-support
7f328db
@simeonoff
refactor(navbar): add support for RTL direction
279e6c9
@simeonoff
Merge branch 'RTL-support' of https://github.com/IgniteUI/igniteui-an…
576b54b 
…gular into RTL-support
feat(Expansion-panel): Adding RTL support for Expansion-panel component
ff81215 
Signed-off-by: MPopov <desig9stein@gmail.com>
Merge remote-tracking branch 'IGX/RTL-support' into RTL-support
edef663
feat(list panning sample): Adding RTL support
acd8266 
Signed-off-by: MPopov <desig9stein@gmail.com>
feat(Navdrawer): Adding RTL support
9974b43 
Signed-off-by: MPopov <desig9stein@gmail.com>
feat(Dropdown): Adding RTL support
e14a433 
Signed-off-by: MPopov <desig9stein@gmail.com>
feat(Navdrawer): Fix mobile RTL support
d9bc2ba 
Signed-off-by: MPopov <desig9stein@gmail.com>
@simeonoff
refactor(calendar): Add support for RTL
930dc25
@simeonoff
refactor(card): Add support for RTL
21a4a38
@simeonoff
refactor(demos): fix the navbar sample for RTL
cb34a8c
@simeonoff
refactor(themes): improve RTL helper mixins and functions
91769a7
@simeonoff
Merge branch 'RTL-support' of https://github.com/IgniteUI/igniteui-an…
f3c1f4b 
…gular into RTL-support
@simeonoff
refactor(demos): Add RTL support in the page header
86d6ba4
Merge branch 'RTL-support' of https://github.com/IgniteUI/igniteui-an…
20af11c 
…gular into RTL-support
@simeonoff
refactor(input-group): Add support for RTL
9106b78
desig9stein
desig9stein previously approved these changes Oct 9, 2019
View reviewed changes
@zdrawku zdrawku assigned hanastasov and unassigned zdrawku Oct 15, 2019
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 15, 2019
@hanastasov
Copy link
Contributor

Those are the visual issues that I have encountered:
Input Group label is positioned in the middle:
switch
NO padding between combo checkbox and text item
inputgroup
Switch looks broken, wider than the original:
combopadding

@simeonoff
Copy link
Collaborator Author

Those are the visual issues that I have encountered:
Input Group label is positioned in the middle:
switch
NO padding between combo checkbox and text item
inputgroup
Switch looks broken, wider than the original:
combopadding

To enable RTL support you must:

  1. Set the $direction property in the igx-core mixin to rtl.
  2. Set the dir attribute on the html element to rtl.

@hanastasov
Copy link
Contributor

  1. Set the dir attribute on the html element to rtl.

This resolved the issues I had.

@hanastasov hanastasov added the ✅ status: verified Applies to PRs that have passed manual verification label Oct 17, 2019
@zdrawku zdrawku merged commit 5187fa7 into 8.2.x Oct 21, 2019
@zdrawku zdrawku deleted the RTL-support branch October 21, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdinev kdinev kdinev approved these changes

@zdrawku zdrawku zdrawku approved these changes

@desig9stein desig9stein desig9stein left review comments

@SAndreeva SAndreeva Awaiting requested review from SAndreeva

Assignees

@hanastasov hanastasov

Labels

material-theme RTL Support version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@simeonoff @hanastasov @kdinev @zdrawku @desig9stein