Skip to content

fix(igxGrid): Fix ExpressionChangedAfterItHasBeenCheckedError when gr… #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 12, 2019
Merged

fix(igxGrid): Fix ExpressionChangedAfterItHasBeenCheckedError when gr… #5942

merged 10 commits into from
Oct 12, 2019

Conversation

@MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Oct 8, 2019

…id.isLoading is set runtime in AfterViewInit.

Closes #5897

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

fix(igxGrid): Fix ExpressionChangedAfterItHasBeenCheckedError when gr…
c989f5b 
…id.isLoading is set runtime in AfterViewInit.
@ChronosSF ChronosSF assigned 3phase and unassigned mpavlinov Oct 9, 2019
@3phase 3phase added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 11, 2019
@ChronosSF ChronosSF merged commit 14a7775 into 8.2.x Oct 12, 2019
@ChronosSF ChronosSF deleted the mkiorva/fix-5897 branch October 12, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

@skrustev skrustev Awaiting requested review from skrustev

Assignees

@ChronosSF ChronosSF

@3phase 3phase

Labels

grid: general version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MayaKirova @ChronosSF @mpavlinov @3phase