Skip to content

fix(igxChip): Fix onSelection.originalEvent not returning correct value. #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 11, 2019
Merged

fix(igxChip): Fix onSelection.originalEvent not returning correct value. #5953

merged 12 commits into from
Oct 11, 2019

Conversation

@skrustev
Copy link
Member

@skrustev skrustev commented Oct 9, 2019 •
edited
Loading

Closes #5940

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification chip version: 8.2.x labels Oct 9, 2019
@skrustev skrustev changed the base branch from master to 8.2.x October 9, 2019 12:56
kdinev
kdinev previously approved these changes Oct 9, 2019
View reviewed changes
dkamburov
dkamburov previously approved these changes Oct 9, 2019
View reviewed changes
@3phase 3phase added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 10, 2019
@3phase 3phase added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 10, 2019
@ChronosSF ChronosSF requested a review from dkamburov October 10, 2019 21:11
@ChronosSF ChronosSF requested a review from kdinev October 10, 2019 21:11
@ChronosSF ChronosSF merged commit 94bc4b1 into 8.2.x Oct 11, 2019
@ChronosSF ChronosSF deleted the SKrastev/fix-5940-8.2.x branch October 11, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkamburov dkamburov dkamburov approved these changes

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@ChronosSF ChronosSF

@3phase 3phase

Labels

chip version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skrustev @dkamburov @kdinev @ChronosSF @3phase