fix(carousel): fix carousel buttons shadow #5969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename $disable-button-shadow to $button-shadow and allow the user to change the default elevation through the theming engine Closes #5680 Signed-off-by: MPopov <desig9stein@gmail.com>
desig9stein
added
material-theme
🎠 carousel
❌ status: awaiting-test
added 2 commits
October 11, 2019 12:41
Signed-off-by: MPopov <desig9stein@gmail.com>
Signed-off-by: MPopov <desig9stein@gmail.com>
simeonoff
previously approved these changes
Oct 14, 2019
Signed-off-by: MPopov <desig9stein@gmail.com>
…arousel-shadow-8.2
simeonoff
requested changes
Oct 14, 2019
Collaborator
simeonoff
left a comment
simeonoff
left a comment
There was a problem hiding this comment.
@desig9stein migrations seem to fail. Can you please check?
simeonoff
added
✅ status: verified
Signed-off-by: MPopov <desig9stein@gmail.com>
simeonoff
approved these changes
Oct 14, 2019
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename $disable-button-shadow to $button-shadow and allow the user to change the default elevation through the theming engine
Closes #5680
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes