Skip to content

fix(grid): instantiate observer and tmpOutlets #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2019
Merged

fix(grid): instantiate observer and tmpOutlets #6021

merged 2 commits into from
Oct 22, 2019

Conversation

@zdrawku
Copy link
Contributor

@zdrawku zdrawku commented Oct 21, 2019 •
edited
Loading

Closes #5804

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@zdrawku zdrawku added ❌ status: awaiting-test PRs awaiting manual verification version: 8.2.x labels Oct 21, 2019
@zdrawku zdrawku requested a review from MayaKirova October 21, 2019 14:46
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification labels Oct 22, 2019
@zdrawku
Copy link
Contributor Author

zdrawku commented Oct 22, 2019

As we spoke, this error was caused by wrong branch checkout

@zdrawku zdrawku merged commit b81aaa0 into 8.2.x Oct 22, 2019
@zdrawku zdrawku deleted the fix-grid-ssr-issue branch October 22, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

Assignees

@hanastasov hanastasov

Labels

version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zdrawku @MayaKirova @hanastasov