fix(igxHierarchicalGrid): Fix navigation with tab is not correct #4780 #6033
Conversation
mddragnev
added
❌ status: awaiting-test
ChronosSF
added
💥 status: in-test
|
This has already been fixed by PR #5900. The current fix is not taken into account because navigating using tab does not go through the igxHierarchicalGrid's navigation service, but through the regular igxGrid navigation service which means overriding the |
| }) | ||
| export class IgxHierarchicalGridSmallerChildComponent extends IgxHierarchicalGridTestBaseComponent {} | ||
|
|
||
| @Component({ |
There was a problem hiding this comment.
Can you use IgxHierarchicalGridTestComplexComponent istead of creating new one
| fixture.detectChanges(); | ||
|
|
||
| const cell = hierarchicalGrid.getCellByColumn(2, 'ProductName'); | ||
| cell.nativeElement.focus(); |
There was a problem hiding this comment.
In order cell to be focused you have to use cell.nativeElement.dispatchEvent(new Event('focus'));
| const keyboardEvent = new KeyboardEvent('keydown', { | ||
| key: 'Tab' | ||
| }); | ||
| cell.dispatchEvent(keyboardEvent); |
There was a problem hiding this comment.
There is defined function for keyboard iterations:
UIInteractions.triggerKeyDownEvtUponElem('Tab', cell.nativeElement, true);
| super(); | ||
| this.data = this.generateData(20, 2); | ||
| } | ||
| generateData(count: number, level: number) { |
There was a problem hiding this comment.
As this method is used more than once you can define it in the sample-test-data.spec.ts. An reuse it in all the definitions.
ChronosSF
requested review from
ChronosSF,
MayaKirova and
nrobakova
and removed request for
MayaKirova and
dkamburov
skrustev
added
✅ status: verified
Closes #4780
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes