Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor keyboard navigation tests #6586

Merged
merged 28 commits into from
Feb 11, 2020
Merged

refactor keyboard navigation tests #6586

merged 28 commits into from
Feb 11, 2020

Conversation

nrobakova
Copy link
Contributor

Closes #6574

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova
chore(*): update keyBoard navigation tests
37f4feb
@nrobakova
Merge branch 'SKrastev/refactor-forOf-tests' of https://github.com/Ig…
8f47a72 
…niteUI/igniteui-angular into nrobakova/refactor-keyboardNav-tests
@nrobakova
chore(*): update keyBoardNavigation tests
3c7be32
@nrobakova
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
681e2a1 
…into nrobakova/refactor-keyboardNav-tests
@nrobakova
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
883fec6 
…into nrobakova/refactor-keyboardNav-tests
@nrobakova
chore(*): update keyBoard navigation tests
218b01d
@nrobakova
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
7504d88 
…into nrobakova/refactor-keyboardNav-tests
@nrobakova
chore(*): update failing tests
2a922f2
@nrobakova
chore(*): update for failing tests
fa81f71
@nrobakova
chore(*): update failing tests
7b74b70
@nrobakova
chore(*): update failing tests
85445c2
@nrobakova
chore(*): update failing tests
b82ddc8
@nrobakova
chore(*): update failing tests
3551243
@nrobakova
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
bb41dca
@nrobakova
chore(*): organize test to compileComponents for describe
819fd99
@nrobakova
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
d3598f3 
…into nrobakova/refactor-keyboardNav-tests
@nrobakova
Merge branch 'nrobakova/refactor-keyboardNav-tests' of https://github…
2825f7c 
….com/IgniteUI/igniteui-angular into nrobakova/refactor-keyboardNav-tests
@nrobakova
chore(*): update for lint error
1ba895f
@nrobakova nrobakova marked this pull request as ready for review February 5, 2020 07:15
@nrobakova nrobakova requested a review from zdrawku February 6, 2020 07:29
@zdrawku zdrawku requested a review from skrustev February 11, 2020 08:47
@zdrawku zdrawku merged commit 359bf7c into master Feb 11, 2020
@zdrawku zdrawku deleted the nrobakova/refactor-keyboardNav-tests branch February 11, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@skrustev skrustev skrustev approved these changes

@igdmdimitrov igdmdimitrov Awaiting requested review from igdmdimitrov

@PlamenaMiteva PlamenaMiteva Awaiting requested review from PlamenaMiteva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests Refactoring: IgxGrid - Keyboard navigation
4 participants
@nrobakova @skrustev @zdrawku @kdinev