Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Multi-row Layout navigation tests #6665

Merged
merged 16 commits into from
Feb 22, 2020
Merged

Refactor Multi-row Layout navigation tests #6665

merged 16 commits into from
Feb 22, 2020

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Feb 11, 2020 •
edited
Loading

Closes #6573

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

nrobakova
nrobakova suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@nrobakova nrobakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new test under describe('Without scrolling') for navigation with home and end on a cell to keep the coverage.

projects/igniteui-angular/src/lib/grids/grid/grid-mrl-keyboard-nav.spec.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-mrl-keyboard-nav.spec.ts Outdated Show resolved Hide resolved
@skrustev skrustev force-pushed the SKrastev/refactor-mrl-nav-test branch from fe25eb8 to 6ff9221 Compare February 18, 2020 12:56
@nrobakova nrobakova self-requested a review February 20, 2020 11:56
@nrobakova nrobakova added the ✅ status: verified Applies to PRs that have passed manual verification label Feb 20, 2020
@ChronosSF ChronosSF merged commit 26a8090 into master Feb 22, 2020
@ChronosSF ChronosSF deleted the SKrastev/refactor-mrl-nav-test branch February 22, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrobakova nrobakova nrobakova approved these changes

@PlamenaMiteva PlamenaMiteva Awaiting requested review from PlamenaMiteva

@DiyanDimitrov DiyanDimitrov Awaiting requested review from DiyanDimitrov

@igdmdimitrov igdmdimitrov Awaiting requested review from igdmdimitrov

Assignees

@ChronosSF ChronosSF

Labels
grid: multi-row-layout refactoring 🧪 ci: tests version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests Refactoring: IgxGrid - multi-row-layout keyboard navigation
3 participants
@skrustev @nrobakova @ChronosSF