Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates iteration 3 - upgrade jasmine and schematics #1318

Merged
merged 62 commits into from
Oct 10, 2024
Merged

Dependency updates iteration 3 - upgrade jasmine and schematics #1318

merged 62 commits into from
Oct 10, 2024

Conversation

Hristo313
Copy link
Contributor

@Hristo313 Hristo313 commented Sep 17, 2024 •
edited
Loading

Related to #1294

This PR upgrades the jasmine, types/jasmine, types/node and devkit packages to latest versions.

Add fixes for the test after the upgrades.

We need to upgrade (Core: chalk & glob) in #1295 , because the changes there are connected.

@jackofdiamond5
chore(*): update fs-extra & types to latest
829c8bc
@jackofdiamond5
chore(*): update browser-sync & lite-server to latest
a89343c
@jackofdiamond5
chore(cli): bump types/node, nyc, fs-extra, types/fs-extra, browser-s…
2aafd5e 
…ync, lite-server
@jackofdiamond5
chore(root; cli): update typescript-json-schema, remove deprecated op…
2f4e7ae 
…n in favor of open
@jackofdiamond5
chore(root; cli): update through2, source-map-support
bc905a2
@jackofdiamond5
chore(cli): bump ts-node
5c233c0
@jackofdiamond5
chore(root; cli): bump chalk, coveralls
c84b473
@jackofdiamond5
chore(root;cli): bump glob, resolve, rxjs, handlebars
89a73e6
@jackofdiamond5
chore(cli): bump yargs
c15ed09
@jackofdiamond5
refactor(cli): update quickstart command; introduce strict types
eca83f3
@jackofdiamond5
refactor(cli): update new command; introduce strict types
787b358
@jackofdiamond5
refactor(cli): rework command chaining; update add command; introduce…
82ead59 
… strict typing
@jackofdiamond5
refactor(cli): update build command; introduce strict types
f2ffa0a
@jackofdiamond5
refactor(cli): update start command; introduce strict types
db719d9
@jackofdiamond5
refactor(cli): update generate command; introduce strict types
9ad3b48
@jackofdiamond5
refactor(cli): update config command; introduce strict types
28336d9
@jackofdiamond5
refactor(cli_: update doc command; introduce strict types
bd6b043
@jackofdiamond5
refactor(cli): update test command; introduce strict types
734b3e0
@jackofdiamond5
refactor(cli): update list command; introduce strict types
768d487
@jackofdiamond5
refactor(cli): update upgrade command; introduce strict types
5af7188
@jackofdiamond5
refactor(cli): setup help command
b769f6e
@jackofdiamond5
refactor(execute): provide args to cli.run
40bbccf
@jackofdiamond5
refactor(cli): disable usage msg on all commands
c62098e
@jackofdiamond5
refactor(cli): check for help on quickstart; use correct upgrade comm…
67cb21e 
…and name
@jackofdiamond5
test(help): introduce tests for all commands
2dde833
@jackofdiamond5
refactor(cli): export commands from an index
e1bc4ca
@jackofdiamond5
docs(cli): add docs for new types
25ab771
@jackofdiamond5
refactor(workflows): remove 18.x for node ci
f5a08b8
@jackofdiamond5
refactor(workflows): generate coverage for 20.x
8fc6d51
@jackofdiamond5
refactor(*): use report-dir for nyc report
ef74720
@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Coverage Status

coverage: 70.407% (-1.0%) from 71.398%
when pulling a611e0c on hhristov/dep-updates-schematics
into e121a9b on master.

Hristo Hristov added 15 commits September 18, 2024 16:26
upgrade through2 core package to latest
ce447d5
refactor(cli): fix AngularTemplate and IginiteUIForAngularTemplate sp…
c550a72 
…ec mocks and expected results
refactor(cli): merge from master
96fb62b
chore: release 14.1.0-beta.0
fb933af
refactor(cli): fix release by setting esModuleInterup to true
eee39c6
refactor(cli): fix release by import yargs with require
d205c44
refactor(cli): fix release by adding allowSyntheticDefaultImports
3eaa083
refactor(cli): fix release by adding esModuleInterop in tsconfig-pack…
daf685a 
….json
refactor(cli): fix release by add missing properties from tsconfig in…
42bff01 
… tsconfig-pack.json
refactor(cli): fix release by adding tsconfig-pack.json in cli
acd6f62
refactor(cli): fix release by adding tsconfig to cli and esModuleInte…
eeaca16 
…rup flag to igx templates config file
refactor(cli): upgrade typescript to 5.5.4
6f31e62
refactor(cli): fix release by setting esModuleInterup to true in proj…
1ac8ccd 
…ects tsconfig
refactor(cli): remove tsconfig files from cli and the properties that…
f7a0b2d 
… are not needed
chore: release 14.1.0-beta.1
83eb24e
jackofdiamond5
jackofdiamond5 reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@jackofdiamond5 jackofdiamond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, we should strive for the same indentation - we have places in the refactored code where we use spaces while we normally use tabs everywhere else in the project.

packages/ng-schematics/src/ng-new/index_spec.ts Outdated Show resolved Hide resolved
packages/ng-schematics/src/component/index_spec.ts Show resolved Hide resolved
packages/ng-schematics/src/ng-new/index_spec.ts Show resolved Hide resolved
packages/ng-schematics/src/upgrade-packages/index.spec.ts Outdated Show resolved Hide resolved
spec/acceptance/add-spec.ts Outdated Show resolved Hide resolved
spec/unit/base-templates/IgniteUIForAngularTemplate-spec.ts Show resolved Hide resolved
spec/unit/new-spec.ts Show resolved Hide resolved
spec/unit/new-spec.ts Show resolved Hide resolved
spec/unit/test-spec.ts Outdated Show resolved Hide resolved
spec/unit/upgrade-spec.ts Outdated Show resolved Hide resolved
@Lipata Lipata merged commit ee2782e into master Oct 10, 2024
3 checks passed
@Lipata Lipata deleted the hhristov/dep-updates-schematics branch October 10, 2024 08:56
Lipata added a commit that referenced this pull request Oct 10, 2024
@Lipata
Revert "Dependency updates iteration 3 - upgrade jasmine and schemati…
6de8cea 
…cs (#1318)"

This reverts commit ee2782e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

@Lipata Lipata Awaiting requested review from Lipata

Assignees

@jackofdiamond5 jackofdiamond5

Labels
cli-package igniteui-cli package improvement step by step ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hristo313 @coveralls @jackofdiamond5 @Lipata