Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(chip): remove duplicated dragging section #5999

Open
wants to merge 4 commits into
base: vnext
Choose a base branch
from
Open

docs(chip): remove duplicated dragging section #5999

wants to merge 4 commits into from

Conversation

teodosiah
Copy link
Contributor

Closes #5998

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

dkamburov
dkamburov reviewed Nov 25, 2024
View reviewed changes
en/components/chip.md
@@ -121,21 +121,6 @@ public chipRemoved(event: IBaseChipEventArgs) {
this.changeDetectionRef.detectChanges();
}
```

### Dragging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see duplicate section of this one. We'll lose this content if removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chip draggable property is also mentioned in the Reorder Chips section

Copy link
Contributor

@dkamburov dkamburov Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added @skrustev for a review, he can tell if this section was added for a reason

@dkamburov dkamburov requested a review from skrustev November 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov dkamburov left review comments

@gedinakova gedinakova Awaiting requested review from gedinakova

@skrustev skrustev Awaiting requested review from skrustev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chip status: awaiting-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teodosiah @dkamburov