Skip to content

Conversation

@tishko0
Copy link
Contributor

@tishko0 tishko0 commented Jul 11, 2025

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this file?


return (
<div className="container sample ig-typography">
<h3>Remote Filtering & Sorting Grid</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong header

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again extra file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this file?

import { IgrColumn, IgrFilteringExpressionsTree, IgrFilteringStrategy } from "igniteui-react-grids";

const DATA_URL = 'https://services.odata.org/V4/Northwind/Northwind.svc/Products';
const EMPTY_STRING = '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variables

const filterExpr = this.buildFilterExpression(filteringArgs);
if (filterExpr) parts.push(filterExpr);

return `${baseQuery}&${parts.join('&')}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem with URL ending in '&'

const result = await RemoteService.getData(filterExpressions, sortExpressions);
setData(result);
} catch (error) {
console.error('Error fetching data:', error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setData([])

@tishko0 tishko0 requested a review from MarielaTihova October 6, 2025 14:22
Copy link
Contributor

@MarielaTihova MarielaTihova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve comments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed

};

useEffect(() => {
fetchData(); // initial load
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we make a new request when we scroll to see the remaining data in the grid instead of fetching everything at once?


public static getData(skip: number = 0, take: number = 50): Promise<any[]> {
try {
if (skip < 0 || take <= 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this file?


// Initialize the filtering strategy for RemoteService
useEffect(() => {
RemoteService._filteringStrategy = new IgrFilteringStrategy();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces an error. Sample doesn't run. Please check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants