Skip to content

fix(sample): clear pin position before pinning to make sure column pi… #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: vnext
Choose a base branch
from
Open

fix(sample): clear pin position before pinning to make sure column pi… #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eefb86b
fix(sample): clear pin position before pinning to make sure column pi…
tishko0 Oct 27, 2025
ab9b305
fix(sample): fixed a typo
tishko0 Oct 27, 2025
582ef6d
fix(sample): removed a white space
tishko0 Oct 27, 2025
06ca5f7
fix(grids): reset pinned state before pinning columns in grid samples
tishko0 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions samples/grids/grid/column-pinning-both-sides/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,16 @@ export default function App() {

const pinLeft = () => {
gridRef.current?.selectedColumns().forEach((col: IgrColumn) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.Start;
col.pinned = true;
col.pinned = true;
});
};
const pinRight = () => {
gridRef.current?.selectedColumns().forEach((col: IgrColumn) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.End;
col.pinned = true;
col.pinned = true;
});
};
const unpinColumn = () => {
Expand Down
2 changes: 2 additions & 0 deletions samples/grids/hierarchical-grid/column-pinning-both-sides/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export default function App() {
const grid = gridRef.current;
if (!grid) return;
grid.selectedColumns().forEach((col) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.Start;
col.pinned = true;
});
Expand All @@ -42,6 +43,7 @@ export default function App() {
const grid = gridRef.current;
if (!grid) return;
grid.selectedColumns().forEach((col) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.End;
col.pinned = true;
});
Expand Down
2 changes: 2 additions & 0 deletions samples/grids/tree-grid/column-pinning-both-sides/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export default function App() {
const grid = gridRef.current;
if (!grid) return;
grid.selectedColumns().forEach((col) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.Start;
col.pinned = true;
});
Expand All @@ -41,6 +42,7 @@ export default function App() {
const grid = gridRef.current;
if (!grid) return;
grid.selectedColumns().forEach((col) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.End;
col.pinned = true;
});
Expand Down