Skip to content

refactor(buttons): remove shadow-related parameters from the outline and flat button themes #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 21, 2025
Merged

refactor(buttons): remove shadow-related parameters from the outline and flat button themes #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
869ed15
refactor(buttons): remove shadow related parameters from the outlined…
adrianptrv Nov 17, 2025
5098d08
Merge branch 'master' into apetrov/remove-shadow-parameters
simeonoff Nov 18, 2025
fba2d89
Merge branch 'master' into apetrov/remove-shadow-parameters
simeonoff Nov 20, 2025
66a1b3d
Merge branch 'master' into apetrov/remove-shadow-parameters
simeonoff Nov 20, 2025
037271a
Merge branch 'master' into apetrov/remove-shadow-parameters
simeonoff Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions sass/themes/components/button/_flat-button-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@
/// @param {Color} $focus-visible-border-color [null] - The focus-visible border color of the button.
/// @param {Color} $active-border-color [null] - The active border color of the button.
/// @param {Color} $shadow-color [null] - The shadow color of the button.
/// @param {Color} $resting-shadow [null] - The shadow of the button in its idle state.
/// @param {Color} $hover-shadow [null] - The shadow of the button in its hover state.
/// @param {Color} $focus-shadow [null] - The shadow of the button in its focus state.
/// @param {Color} $active-shadow [null] - The shadow of the button in its focus state.
/// @param {Color} $disabled-background [null] - The disabled background color of the button.
/// @param {Color} $disabled-foreground [null] - The disabled text color of the button.
/// @param {Color} $disabled-icon-color [null] - The disabled icon color of the button.
Expand Down Expand Up @@ -89,11 +85,6 @@

$shadow-color: null,

$resting-shadow: null,
$hover-shadow: null,
$focus-shadow: null,
$active-shadow: null,

$disabled-background: null,
$disabled-foreground: null,
$disabled-icon-color: $disabled-foreground,
Expand Down Expand Up @@ -283,26 +274,6 @@
}
}

@if not($resting-shadow) {
$resting-elevation: map.get($button-schema, 'resting-elevation');
$resting-shadow: elevation($resting-elevation);
}

@if not($hover-shadow) {
$hover-elevation: map.get($button-schema, 'hover-elevation');
$hover-shadow: elevation($hover-elevation);
}

@if not($focus-shadow) {
$focus-elevation: map.get($button-schema, 'focus-elevation');
$focus-shadow: elevation($focus-elevation);
}

@if not($active-shadow) {
$active-elevation: map.get($button-schema, 'active-elevation');
$active-shadow: elevation($active-elevation);
}

@return extend(
$theme,
(
Expand All @@ -329,10 +300,6 @@
focus-visible-border-color: $focus-visible-border-color,
active-border-color: $active-border-color,
shadow-color: $shadow-color,
resting-elevation: $resting-shadow,
hover-elevation: $hover-shadow,
focus-elevation: $focus-shadow,
active-elevation: $active-shadow,
disabled-background: $disabled-background,
disabled-foreground: $disabled-foreground,
disabled-icon-color: $disabled-icon-color,
Expand Down
33 changes: 0 additions & 33 deletions sass/themes/components/button/_outlined-button-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@
/// @param {Color} $focus-visible-border-color [null] - The focus-visible border color of the button.
/// @param {Color} $active-border-color [null] - The active border color of the button.
/// @param {Color} $shadow-color [null] - The shadow color of the button.
/// @param {Color} $resting-shadow [null] - The shadow of the button in its idle state.
/// @param {Color} $hover-shadow [null] - The shadow of the button in its hover state.
/// @param {Color} $focus-shadow [null] - The shadow of the button in its focus state.
/// @param {Color} $active-shadow [null] - The shadow of the button in its focus state.
/// @param {Color} $disabled-background [null] - The disabled background color of the button.
/// @param {Color} $disabled-foreground [null] - The disabled text color of the button.
/// @param {Color} $disabled-icon-color [null] - The disabled icon color of the button.
Expand Down Expand Up @@ -89,11 +85,6 @@

$shadow-color: null,

$resting-shadow: null,
$hover-shadow: null,
$focus-shadow: null,
$active-shadow: null,

$disabled-background: null,
$disabled-foreground: null,
$disabled-icon-color: $disabled-foreground,
Expand Down Expand Up @@ -349,26 +340,6 @@
}
}

@if not($resting-shadow) {
$resting-elevation: map.get($button-schema, 'resting-elevation');
$resting-shadow: elevation($resting-elevation);
}

@if not($hover-shadow) {
$hover-elevation: map.get($button-schema, 'hover-elevation');
$hover-shadow: elevation($hover-elevation);
}

@if not($focus-shadow) {
$focus-elevation: map.get($button-schema, 'focus-elevation');
$focus-shadow: elevation($focus-elevation);
}

@if not($active-shadow) {
$active-elevation: map.get($button-schema, 'active-elevation');
$active-shadow: elevation($active-elevation);
}

@return extend(
$theme,
(
Expand All @@ -395,10 +366,6 @@
focus-visible-border-color: $focus-visible-border-color,
active-border-color: $active-border-color,
shadow-color: $shadow-color,
resting-elevation: $resting-shadow,
hover-elevation: $hover-shadow,
focus-elevation: $focus-shadow,
active-elevation: $active-shadow,
disabled-background: $disabled-background,
disabled-foreground: $disabled-foreground,
disabled-icon-color: $disabled-icon-color,
Expand Down