feat(radio-group): Set radio properties through the group #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `name` and `value` properties on the igc-radio-group. Developers can now control the checked state of the underlying igc-radio components through the enclosing group. Closes #315
|
LGTM |
This shouldn't be an issue in normal scenarios. If it is bound as an attribute both 0 and false are coerced to truthy string values. If you try to set them through a property assignment on a string property that is just a developer being sloppy. |
…onents into rkaraivanov/radio-group-enhancement
…onents into rkaraivanov/radio-group-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
nameandvalueproperties on the igc-radio-group. Developers can now control the checked state of the underlying igc-radio components through the enclosing group.Closes #315