fix(dropdown): Various dropdown fixes #434
Conversation
* Dropdown now supports navigation with Home/End keys. * Dropdown now supports initial selection through `selected` attribute on its items. In case of multiple items, the last in the DOM hierarchy wins. * Fixed an issue with `igcChange` being emitted twice when making selection. * Fixed dropdown `opened/closed` events to be emitted after the underlying DOM is updated. * Fixed dropdown closing events not being emitted when clicking around the page with `keepOpenOnOutsideClick` set to false. * Fixed toggle directive `sameWidth` option to correctly reset the floater element styles after being turned off.
| @@ -26,7 +26,6 @@ export default class IgcDropdownGroupComponent extends LitElement { | |||
| @queryAssignedElements({ flatten: true, selector: 'igc-dropdown-item' }) | |||
| public items!: Array<IgcDropdownItemComponent>; | |||
|
|
|||
| /** @private */ | |||
There was a problem hiding this comment.
Not sure if this interferes with anything, but if possible do leave it private. The groups and items under a dropdown are supposed to strictly inherit the size of the parent and doesn't make sense for them to be different. Guessing this is exposed to facilitate that and if or should I say when we tackle the global size through themes this will inherit from cascade and be obsoleted/removed.
There was a problem hiding this comment.
Maybe as an alternative make the group items get the size from their parent instead of exposing an additional attribute.
Even with the private tag this would show in auto-complete in editors. Not to mention that the dropdown overwrites the value anyway...
There was a problem hiding this comment.
Agreed, the way you refactored it is likely better, however.. when the child looks for its parent explicitly it won't be super friendly for extended components (looking at the select, combo maybe). Perhaps generalize the parent with some base interface and move the query for it in a protected getParent() or something similar.
…onents into rkaraivanov/dropdown-fixes
selectedattributeon its items. In case of multiple items, the last in the DOM hierarchy
wins.
igcChangebeing emitted twice when making selection.opened/closedevents to be emitted after the underlyingDOM is updated.
the page with
keepOpenOnOutsideClickset to false.sameWidthoption to correctly reset the floaterelement styles after being turned off.
Closes #413
Closes #414
Closes #419