Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark package with developmentDependency=true #15

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

kkm000
Copy link
Contributor

@kkm000 kkm000 commented Dec 9, 2017

Because it is, otherwise the package is added as dependency of the project importing the package.

Unfortunately, this is broken atm with the SDK projects (NuGet/Home#4125), but works with "classic" projects. With SDK, the user has to add the PrivateAssets=All attribute:

  <ItemGroup>
    <PackageReference Include="CodeContracts.MSBuild" Version="1.11.0-alpha" PrivateAssets="All" />
  </ItemGroup>

@Igorbek Igorbek merged commit 4fd7dcb into Igorbek:master Dec 19, 2017
@Igorbek
Copy link
Owner

Igorbek commented Dec 19, 2017

Thank you for the contribution and sorry for the late response. I was on vacation.

@Igorbek
Copy link
Owner

Igorbek commented Dec 19, 2017

Let's bundle your other changes for the next release.

Igorbek added a commit that referenced this pull request Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants