Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify option breaks styles #36

Closed
Ky6uk opened this issue Mar 20, 2019 · 4 comments · Fixed by #39
Closed

minify option breaks styles #36

Ky6uk opened this issue Mar 20, 2019 · 4 comments · Fixed by #39

Comments

@Ky6uk
Copy link

Ky6uk commented Mar 20, 2019

I'm still investigating the code blocks but what I found for a quick look that option breaks animations through transition property and some paddings/margins. I will add code samples in the future.

@Igorbek
Copy link
Owner

Igorbek commented Mar 22, 2019

Yes, please give some sample code.
I have tested on quite a big codebase (-30kb by minification) and didn't find issues so far.

@Igorbek Igorbek self-assigned this Mar 22, 2019
@Igorbek Igorbek added this to the Release 1.4.1 milestone Mar 22, 2019
@Ky6uk
Copy link
Author

Ky6uk commented Mar 26, 2019

One of the problems is keyframes.

https://github.com/Ky6uk/typescript-plugin-styled-components-36

You can try different builds with minify: true and minify: false.

@Igorbek
Copy link
Owner

Igorbek commented Mar 26, 2019

Thank you, @Ky6uk
It seems the issue is when a placeholder followed by spaces and then numeric values: ${smth} 2s -> ${smth}2s, which when it gets interpolated has no separation. I'll look into this shortly.

Igorbek added a commit that referenced this issue Mar 27, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix minification issues #36
@Igorbek
Copy link
Owner

Igorbek commented Mar 27, 2019

The fix has been release as of 1.4.1.

@Igorbek Igorbek added the fixed label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants