Skip to content

Conversation

Bdthomson
Copy link

@Bdthomson Bdthomson commented Aug 20, 2019

.extend was removed from styled-components in v4 (styled-components/styled-components#1908),

This PR removes support for it in this plugin so it no longer has to be maintained, fixing issues similar #33.

TODO

  • Cleaning up tests (if maintainer will accept the change)

Fixes #48

.extend was deprecated in styled-components v4
@Igorbek
Copy link
Owner

Igorbek commented Aug 20, 2019

@Bdthomson thank you for the contribution!
I suggest adding extend to the Options.CustomStyledIdentifiers. And make the default value an empty array. In this case, if anybody wants to keep existing extends they can define it in the options.

@Igorbek
Copy link
Owner

Igorbek commented Apr 8, 2021

I'm closing as it's been superseded by #370

@Igorbek Igorbek closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate extend method on a component
2 participants