Skip to content

Commit

Permalink
remove nodeport
Browse files Browse the repository at this point in the history
  • Loading branch information
IhsenBouallegue committed Dec 15, 2022
1 parent b657ac8 commit 4ea0647
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion charts/hubone/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.1
version: 2.0.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 1 addition & 3 deletions charts/hubone/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
targetPort: {{ .Values.service.port }}
nodePort: {{ .Values.service.nodePort }}
protocol: TCP
name: http
targetPort: {{ .Values.service.port }}
selector:
{{- include "hubone.selectorLabels" . | nindent 4 }}
7 changes: 3 additions & 4 deletions charts/hubone/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,19 @@ serviceAccount:
# If not set and create is true, a name is generated using the fullname template
name: "hubone"

podAnnotations:
podAnnotations:
argocd.argoproj.io/sync-wave: "2"

service:
type: NodePort
port: 3000
nodePort: 30200
annotations:
annotations:
argocd.argoproj.io/sync-wave: "2"

ingress:
enabled: true
className: ""
annotations:
annotations:
kubernetes.io/ingress.class: nginx
argocd.argoproj.io/sync-wave: "3"

Expand Down

0 comments on commit 4ea0647

Please sign in to comment.