[ME] Projector support #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManlyMarco
reviewed
Apr 20, 2024
src/MaterialEditor.Core.Studio/Core.MaterialEditor.SceneController.cs
Outdated
Show resolved
Hide resolved
|
Here are the projectors for KK/KKS And those for HS/HS2/AI are included with RE |
ManlyMarco
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projector support for ME. Formely you had to use Render Editor to edit them in games that had projectors. Koikatsu doesn't have them yet, but I'm porting those, but then RE doesn't exist on KKS.
All projector properties are treated as material properties in the UI, and thus grouped together with them. I did it like this to make editing them a little easier (grouped together + copy/pasting edits), and since projectors can only ever have one material anyway. Since projectors can only have one material, I also hide the "Copy Material" button now whenever the provided function for that button is
null.Fow now I've made all character versions of the projector methods throw a
NotImplementedException, since projectors don't seem to be used there at all. If the rest of the code is fine I will add those functions for completeness sake though (and in case they do exist there, though I doubt that)There is also the problem of potential conflicts with RE, This is because projectors share their material instance by default, while renderer materials do not. To circumvent this you need to assign a unique copy yourself and keep track if you've already assigned a unique copy or not. RE seems to do this, and might cause conflicts.
In my testing they don't conflict for some reason though, except for the
orthographicsetting, which can't be edited in ME if it's enabled in RE