Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ME] Simple refactoring #254

Merged
merged 5 commits into from
May 26, 2024
Merged

Conversation

takahiro0327
Copy link
Collaborator

Some code was made into a function. The main purpose is to clean up duplicated code.
There are no functional changes.
Please merge if you like.

It will make it easier to hook specific processes from the outside and should make future changes somewhat easier.
If there are changes that add functions, such as ConvertNormalMap, for example, the changes should be limited to one or two places in each Controller.

@takahiro0327
Copy link
Collaborator Author

Sorry, I'll make some changes, just give me a minute.

@takahiro0327 takahiro0327 marked this pull request as draft May 26, 2024 12:32
@takahiro0327
Copy link
Collaborator Author

Fixes are done.
Please review.

@takahiro0327 takahiro0327 marked this pull request as ready for review May 26, 2024 14:08
@ManlyMarco ManlyMarco merged commit 1fb9546 into IllusionMods:master May 26, 2024
@takahiro0327
Copy link
Collaborator Author

Thanks for the merge.
If you plan to version or release ME, give me a few days.
I think I'll put in a fix for the problem with the reset button not working if a shader not in the shader list was the initial selection.

@takahiro0327
Copy link
Collaborator Author

@ManlyMarco
Feel free to bump up the version or release.

It turns out that there are some difficult issues involved. Like mixing up shaders with the same name. It's going to be hard to reliably revert to the original shaders unless I can get some dirty code between them. I give up for now.

@ManlyMarco
Copy link
Contributor

@takahiro0327 Got it, thanks for letting me know. I'll probably make a release around the weekend.

@takahiro0327 takahiro0327 deleted the me-refactoring branch June 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants