Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from pydata:main #559

Merged
merged 10 commits into from
Dec 1, 2023
Merged

[pull] main from pydata:main #559

merged 10 commits into from
Dec 1, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 1, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

maxrjones and others added 10 commits November 27, 2023 22:29
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
* Start renaming `dims` to `dim`

Begins the process of #6646. I don't think it's feasible / enjoyable to do this for everything at once, so I would suggest we do it gradually, while keeping the warnings quite quiet, so by the time we convert to louder warnings, users can do a find/replace easily.

* No deprecation for internal methods

* Simplify typing
…4700)

Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
* Improve FutureWarning re: resample() loffset parameter

As discussed in #8175

* Add docs re: resample time offset arithmetic

Illustrate updating the time coordinate values of a resampled dataset
using time offset arithmetic. This is the recommended technique to
replace the use of the deprecated `loffset` parameter in `resample()`

re: issue #7596 and discussion
#8175

* Add loffset deprecation warning to resample docstrings

* Add docs change to whats-new.rst

* Drop redundant FutureWarning in warning text

* Change deprecation warning to present tense

* Add code example for FutureWarning message

---------

Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
…th `append_dim` (#8428)

Co-authored-by: Deepak Cherian <deepak@cherian.net>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants