Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env var GITHUB_ACTION is not defined. Maybe try to set it if you are running the script manually. #39

Closed
bluelovers opened this issue Aug 4, 2020 · 5 comments
Closed

Env var GITHUB_ACTION is not defined. Maybe try to set it if you are running the script manually. #39

bluelovers opened this issue Aug 4, 2020 · 5 comments
Assignees
@Ilshidur
Labels
bug Something isn't working

Comments

@bluelovers
Copy link

https://github.com/bluelovers/ws-segment/runs/943356195?check_suite_focus=true
@foosel
Copy link

foosel commented Aug 4, 2020

Seeing the same, probably caused by actions/runner#635

@Ilshidur Ilshidur self-assigned this Aug 4, 2020
@Ilshidur Ilshidur added the bug Something isn't working label Aug 4, 2020
@Ilshidur
Copy link
Owner

Ilshidur commented Aug 4, 2020 •
edited
Loading

Looks like an issue on GitHub's end. I'll deploy a quick fix until they solve this.

Ilshidur pushed a commit that referenced this issue Aug 4, 2020
fix(#39): set "GITHUB_ACTION" env var as optional
fbd91a9
@Ilshidur
Copy link
Owner

Ilshidur commented Aug 4, 2020 •
edited
Loading

Fix is pushed. Bumped as a minor semver release from 0.1.0 to 0.2.0 (see here why).

To fix your pipeline, check sure the version you use is at least Ilshidur/actions-discord@0.2.0 (or Ilshidur/actions-discord@6d08557). Here's a link to the commits list for clearance.
You should be fine if your Action is not locked on a certain version SHA-1 (e.g.: Ilshidur/actions-discord@master).

I'll have a close look on GitHub's behavior concerning this issue. Thank you.

foosel added a commit to OctoPrint/octoprint.org that referenced this issue Aug 4, 2020
@foosel
💚 Use Ilshidur/action-discord w/ workaround for actions/runner#635
b4d0018 
There's currently an issue the current version of github's runners
that's causing GITHUB_ACTION to be unset which in turn causes problems
for Ilshidur/action-discord@master, leading to failed builds

See Ilshidur/action-discord#39 and actions/runner#635
foosel added a commit to OctoPrint/plugins.octoprint.org that referenced this issue Aug 4, 2020
@foosel
💚 Use Ilshidur/action-discord w/ workaround for actions/runner#635
edb3942 
There's currently an issue the current version of github's runners
that's causing GITHUB_ACTION to be unset which in turn causes problems
for Ilshidur/action-discord@master, leading to failed builds

See Ilshidur/action-discord#39 and actions/runner#635
@foosel
Copy link

foosel commented Aug 4, 2020

@Ilshidur Lovely, thank you for the quick turn around! I was just about to disable discord notifications on my project until Github fixes this on their end, but you just made that unnecessary. Thank you for your awesome work!

@Ilshidur
Copy link
Owner

Ilshidur commented Aug 4, 2020

Thank you for your the link your provided. It made it clearly quicker to fix !

I'll be closing this issue. Feel free to comment below in case anything goes wrong again.

@Ilshidur Ilshidur closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ilshidur Ilshidur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foosel @bluelovers @Ilshidur