ie options: Fix Python 3 exec issue with list comprehensions
#1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3 list comprehensions were changed to create their own local scope. If we pass in different objects for the `globals` and `locals` to the `exec` function this leads to `NameErrors` in the list comprehension. SCons passes in two different dictionaries when calling `exec` on the the options files. To circumvent this issue, we rewrite the list comprehension to a loop. For reference: https://stackoverflow.com/questions/45132645/list-comprehension-in-exec-with-empty-locals-nameerror
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3 list comprehensions were changed to create their own local scope. If we pass in different objects for the
globalsandlocalsto theexecfunction this leads toNameErrorsin the list comprehension. SCons passes in two different dictionaries when callingexecon the the options files. To circumvent this issue, we rewrite the list comprehension to a loop.For reference:
https://stackoverflow.com/questions/45132645/list-comprehension-in-exec-with-empty-locals-nameerror