Visibility override fixes

[yannci]

PR #1290 addressed various issues when drawing scene caches in maya's ViewPort2. This PR attempts to fix a regression introduced by this PR. The actual visibility determination is done correctly by LiveScene but then stomped over by any value present in the cache itself, disregarding overrides made in the scene. This change was introduces to fix an issue where lower level locations would be drawn even with an override higher up. But with the LiveScene implementation this seems not needed anymore.

We also address an issue for scene shapes that represent a root location, e.g. when we have set it to objectOnly where the various instances never checked visibility when set to "draw root bounds". That means we would always draw the bounds in the viewport even when overriding the visibility.

[ivanimanishi]

Shouldn't this be a PR to RB-10.3?

[yannci]

Shouldn't this be a PR to RB-10.3?

Thanks for the catch! Changed the base branch to RB-10.3

[bradleyhenke]

I poked my head in here out of curiosity after running into Yannic on the street a while back. I'm glad you got it all sorted now!

I will say that one benefit of having that check in the code was the ability to prune the traversal of any hidden child locations. Without it, you could potentially lose a little performance if you visit a large number of descendent locations unnecessarily. I don't have a build of cortex readily available, but I wonder if it would be enough to use the visibility info gathered from LiveScene (via m_instances) if you are dealing with a root location, and fall back to the visibility attribute in the cache for any unexpanded locations? The unexpanded locations shouldn't have any way of being overridden, so I think it would be safe to read that value from the cache.

if(isRoot)
{
	if( std::none_of(m_instances.cbegin(), m_instance.cend(), [](const Instance &instance){ instance.visible } )
	{
		return;
	}
}
else
{
	if( sceneInterface->hasAttribute( SceneInterface::visibilityName ) )
	{
		ConstBoolDataPtr vis = runTimeCast<const BoolData>( sceneInterface->readAttribute( SceneInterface::visibilityName, m_time ) );
		if( vis && !vis->readable() )
		{
			return;
		}
	}
}