Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IECoreUSD::ShaderAlgo : Round-trip ColorSpace data on shader parameters. #1453

Open
wants to merge 1 commit into
base: RB-10.5
Choose a base branch
from

Conversation

boberfly
Copy link
Contributor

Generally describe what this PR will do, and why it is needed.

  • Round-trip ColorSpace data on USD attributes, so shaders authored expecting this to work will faithfully translate correctly.

Related Issues

  • While doing IECoreMaterialX work, I noticed ColorSpace on shaders don't round-trip.

Dependencies

  • N/A

Breaking Changes

  • Not sure if it is considered a breaking change, but it does fix up things. Maybe if you are dependent on <paramName>_colorspace parameters existing as real parameters on the USD side, then it'll be problematic but I doubt it would be in-practice. Looking at aiImage they use a dedicated color_space parameter so I doubt it.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

I am using the CI to test this one as I've not got Cortex setup in a proper way yet, thanks! :)

@boberfly boberfly force-pushed the feature/usdColorspace branch 8 times, most recently from 89e210e to 9c4b8e5 Compare February 28, 2025 09:49
@boberfly boberfly force-pushed the feature/usdColorspace branch from 9c4b8e5 to ab4680c Compare February 28, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant