oneTBB 2021 Compatibility #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Jan 8, 2026
Member
johnhaddon
left a comment
johnhaddon
left a comment
There was a problem hiding this comment.
Thanks Murray - LGTM apart from the task_group_context stuff.
I've aimed to keep the changes to PrimitiveAlgoUtils::SplitTask minimal, and am relying on the existing test coverage. It's not used in Gaffer and may be a candidate for moving to IECoreHoudini if that is the only client...
Looks like it is used in Cortex still - PointsAlgo::segment() and CurvesAlgo::segment() use it via TaskSegmenter, so it probably can't be moved just yet. I wouldn't want to rely on this approach in Gaffer though - I'm convinced that much better approaches exist, as Daniel demonstrated for MeshAlgo::segment() a while back.
Member
|
Thanks for the fixups - LGTM. |
The low-level `tbb::task` API was removed from oneTBB 2021. Switching these over to `parallel_for` is the simplest change that is supported by both TBB 2020 and oneTBB 2021, allowing us to target VFX Platform CY2024 & CY2025.
recursive_mutex.h is deprecated in TBB 2020 and removed from oneTBB 2021
`tbb::task_scheduler_init` is deprecated in TBB 2020 and was removed from oneTBB 2021, so we no longer provide the Python context manager wrapper and migrate any usage of `tbb_task_scheduler_init` to `tbb_global_control`.
murraystevenson
force-pushed
the
oneTBB2021
branch
from
c9ba235 to
11b9348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues our journey towards VFX Platform CY2025 by adding support for oneTBB 2021. TBB 2020 is still supported so we can also target CY2024.
I've aimed to keep the changes to
PrimitiveAlgoUtils::SplitTaskminimal, and am relying on the existing test coverage. It's not used in Gaffer and may be a candidate for moving to IECoreHoudini if that is the only client...